[ralphy]

[member=2]Jerry[/member] ,

Lite Tweaks has been moved to pkexec :)

Few notes just in case you wonder:

1- I removed over 250 lines in lite-tweaks-super (code cleanup)
2- lite-tweaks-super will ask for Admin password only once while executed, meaning that as long as Lite Tweaks is open and an admin has authenticated once, it will not prompt for the password over and over again for each tweak that requires admin privileges. This is a good way not to nag users constantly when they want to run additional tweaks without leaving the application.

There is more to cleanup in lite-tweaks script and I will be putting some energy into that later. I have taken notes of few sections that can be improved as well as polishing some of the existing tweaks but since we are moving from gksu to pkexec I didn't want to loose focus and put the energy towards testing it as much as I could.

Give it a good run please. I tested as much as I could before pushing it up as I said. It looks fine on my end.

Cheers!

[valtam]

Cheers Ralphy, will test today.

[valtam]

Seems to be the only bug.

Code:

Package System Repair
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
mv: cannot move 'lists' to 'lists.old/lists': Directory not empty
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.

[valtam]

Seems that if /var/lib/apt/lists.old dir already exists, Lite Tweaks will error out. I deleted the dir, re-ran Package System Repair and it ran without issue. Perhaps we need to include a check for this dir in the code.

[valtam]

Include Package System Repair check pushed to GH. If you're happy, we can release.

[valtam]

Idea - I don't think 'Autoremove Packages' should show in the list if there are none to remove. If there are packages to remove, we should show the number of packages to be autoremoved. Thoughts?

Code:

apt-get --dry-run autoremove | grep -Po '^Remv \K[^ ]+' | awk '{print $0}' | wc -w

[ralphy]

Include Package System Repair check pushed to GH. If you're happy, we can release.

Yes this is helpful but hold on to it for a bit longer. I have found inconsistencies in lite-tweaks that I would like to polish up before we release it. The code needs a review and a cleanup cos' there is been lines thrown over time and as it grows nobody has reviewed it much. 

Idea - I don't think 'Autoremove Packages' should show in the list if there are none to remove. If there are packages to remove, we should show the number of packages to be autoremoved. Thoughts?

Code:

apt-get --dry-run autoremove | grep -Po '^Remv \K[^ ]+' | awk '{print $0}' | wc -w

I like the idea but running the dry apt-get doesn't make it optimal for execution. Lite Tweaks will take a couple of seconds to pop up in lesser hardware. We need to test this...

Here, let's leave everything as it is right now and allow me to cleanup the code first. There is a little "mess" I don't like in lite-tweaks and it is making the code harder to maintain, plus I found small incoherences tat I'm working out. Like I said earlier today, there are few tweaks that can get some love but I need cleaner code first...

Here is my workflow on this for your consideration:

1- I'm pulling the check in Package System Repair from GH and leave everything else as is.
2- I'm cleaning the code for lite-tweaks as we did for lite-tweaks-super (more than 200 lines in the code got removed)
3- We come back to tweaks/improvements discussion - I have some of my own I wanna share with you too.

Can we agree upon this so that we don't overwrite each others work?

[valtam]

Agreed.

Sent from my Mobile phone using Tapatalk

[ralphy]

Cleanup done! I have committed changes to master. Please feel free to release this already once it passes your tests. It addresses a bug in Default Web Browser tweak and also brings it up par with our other apps already on pkexec :)

We can then come back to these other improvements you mentioned and continue to enrich LT as agreed.

Cheers Jerry!

[valtam]

Will do. Thanks Ralphy.

Sent from my Mobile phone using Tapatalk