[ralphy]

Another issue. Lite Welcome is not updated correctly to latest version. It did this on both archs:

This is only possible if:

1- lite-upgrade failed (which it did when dpkg failed to install it - we already have an answer for this)
2- the pc did not execute the new lite-upgrade, which likely it didn't because of #1

[valtam]

I need for you to help me debugging these things Jerry.

I do, but it's not always easy. If you've written the code, I prefer to leave it with you until it's bug free, in the meantime, the least I can do is give feedback, logs etc. If I wrote the code, I would also have a better view and understanding.

[ralphy]

I also noticed in 3.0 log... error: cp: cannot stat '/etc/skel/.config/htop/htoprc': No such file or directory

There is no breakage in the script for this and it should be ignored and continue with the rest of the install. Will confirm after my 3.0  finishes upgrading to 3.4.. it is running

[valtam]

I also noticed in 3.0 log... error: cp: cannot stat '/etc/skel/.config/htop/htoprc': No such file or directory

There is no breakage in the script for this and it should be ignored and continue with the rest of the install. Will confirm after my 3.0  finishes upgrading to 3.4.. it is running

I saw that too and didn't mention it because it had no effect on the process.

[ralphy]

[quote author=ralphy link=topic=3961.msg31172#msg31172 date=1492506892]

I need for you to help me debugging these things Jerry.

I do, but it's not always easy. If you've written the code, I prefer to leave it with you until it's bug free, in the meantime, the least I can do is give feedback, logs etc. If I wrote the code, I would also have a better view and understanding.
[/quote]

The error was not in lite-upgrade code, Jerry (which I have kept almost identical to the previous version with minor improvements such as logging and privileges escalation to prevent the whole process from running unnecessarily). It was in postinst because we checked the start and updates files assuming that the parent folder existed, it does for 3.2 but doesn't in 3.0. This could have happened with the old version too as soon as we tried to check a file and set execute permissions where the parent folder doesn't exist.

I'm not blaming anyone; these things happen, specially considering that we have improved and adjusted so many things from that we had in the code when I first joined in. It is been quite a lot, honestly. Irrespective, I consider this a "minor" issue because the initial code never gave us logs to see what was actually happening nor it set correct permissions recursively as we do now.

Anyways, I'm gonna push the fix to master now... 3.0 upgraded to 3.4 issues free:  :D

- It corrected the missing file in / etc/llver
- Welcome screen was upgraded
- widget got upgraded
- no errors in postinst

This is how I tested it:

Test 1
1- Installed 3.0 Fresh
2- Install Updates
3- replace lite-upgrade old with lite-upgrade new
4- Run upgrade

Test 2
1- Installed 3.0 Fresh (No updates during installation or after)
2- replace lite-upgrade old with lite-upgrade new
4- Run upgrade

Success both times.

[valtam]

3.0 - Upgrade completed successfully on both arch's with no major errors. I'll go over each variable and report back that everything was applied.
I also now have to retest 3.2 upgrading again, and do the same check as above. Then I have work, so will look to get this packaged and out tomorrow.

[ralphy]

No need to rush it boss. I want to get it out because it addresses few issues we already know about... I'm testing also and looking to see if I can spot something out of place. Then again; we are in no rush to push it out there for the most part.

[ralphy]

3.0 - Upgrade completed successfully on both arch's with no major errors.

Between, this is great news! :)

[valtam]

If this is tested and working on 3.0 and 3.2 and all settings are applied, I'll put a package out. Tidying code and fixing no-urgent errors can come later. All it has to do at the moment, it pass the tests. We're more than half way through April and we can assume that most of those that wanted to upgrade, have. So we've missed the boat so to speak. What I'd like to do is integrate a notification into Lite Updates Notify saying there is a Series 3.x upgrade available. But that's a topic for another time.

[ralphy]

Minor glitch: Odd! I just found that permissions for the .config folder under / etc/skel are not root:root

ralphy ralphy  4096 Sep 20  2016 .config

So, we gonna check the code to see where is it applying the $USER as the folder owner... It should be root:root - at least that's what we have in postinst