[ralphy]

Hi Jerry,

The following applications have been updated with new gksu dialogs so far.

- Create System Report
- Install Updates
- Enable Auto Login
- Disable Auto Login
- Lite Tweaks

These applications no longer execute with Exec=gksu... gksu has been moved into the application code. All changes have been committed and pushed to master.

In the case of Install updates, the .desktop is being sed and modified in the postinst script.

Cheers!

[valtam]

Fantastic Ralphy, you rock! Just let me know when you are happy for me to release a new package.

[ralphy]

Fantastic Ralphy, you rock! Just let me know when you are happy for me to release a new package.

Lets just wait for me to address a little issue I found with Lite Tweaks. For some reasons the Default Browser Tweak is not sed'ing text/html option which causes the browser not to be used as default.

I just noticed it happening and I can't pintpoint when was this bug introduced. It certainly needs fixing.

Also, we need to check the postinst script. If you would like to go ahead and create a test package and check whether no errors are tbrown now I would appreciate it.

Having these two things addressed, I think we are ready to push another update. I have tested every other app Ive worked on and they checked out for me.

[valtam]

Lite Tweaks current dpkg output:

Code:

root@jerry-VirtualBox:/home/jerry# dpkg -i litetweaks_2.0-0160-linuxlite.deb
(Reading database ... 174465 files and directories currently installed.)
Preparing to unpack litetweaks_2.0-0160-linuxlite.deb ...
Unpacking lite-tweaks (2.0-0160-linuxlite) over (2.0-0150-linuxlite) ...
Setting up lite-tweaks (2.0-0160-linuxlite) ...
dpkg: error processing package lite-tweaks (--install):
subprocess installed post-installation script returned error exit status 1
Processing triggers for gnome-menus (3.13.3-6ubuntu3.1) ...
Processing triggers for desktop-file-utils (0.22-1ubuntu5) ...
Processing triggers for mime-support (3.59ubuntu1) ...
Errors were encountered while processing:
lite-tweaks
root@jerry-VirtualBox:/home/jerry#

[valtam]

I see also that Lite Tweaks has been pushed to the bottom of Menu, System.
App used to be called Lite Cleaner, my bad, I should have renamed this in Series 3.x  :-\

[ralphy]

Lite Tweaks current dpkg output:

Code:

root@jerry-VirtualBox:/home/jerry# dpkg -i litetweaks_2.0-0160-linuxlite.deb
(Reading database ... 174465 files and directories currently installed.)
Preparing to unpack litetweaks_2.0-0160-linuxlite.deb ...
Unpacking lite-tweaks (2.0-0160-linuxlite) over (2.0-0150-linuxlite) ...
Setting up lite-tweaks (2.0-0160-linuxlite) ...
dpkg: error processing package lite-tweaks (--install):
subprocess installed post-installation script returned error exit status 1
Processing triggers for gnome-menus (3.13.3-6ubuntu3.1) ...
Processing triggers for desktop-file-utils (0.22-1ubuntu5) ...
Processing triggers for mime-support (3.59ubuntu1) ...
Errors were encountered while processing:
lite-tweaks
root@jerry-VirtualBox:/home/jerry#

I believe this doesn't have to do with the script but with the fact that lite-tweaks package is a "required" package hence cannot be removed. The control file is what I believe needs to be updated accordingly.

Here is the postinst script with echo(s) to see how far it goes in the execution:

Code:

#! /bin/sh
set -e
# Postinst script for bug fixes for 3.x Series
# Fix 'virtualbox kernel service is not running'
# As reported here - https://www.linuxliteos.com/forums/other/vboxclient-the-virtualbox-kernel-service-is-not-running/
# Fix is here - https://www.linuxliteos.com/forums/other/vboxclient-the-virtualbox-kernel-service-is-not-running/msg19295/#msg19295
FILE="/etc/X11/Xsession.d/98vboxadd-xclient"
if [ -s "$FILE" ]; then
    sudo sed -i "s/notify-send/echo/g" $FILE
        else :
fi
echo 'passed virtual box'
# File ownership
chown root:root /usr/share/applications/createsysreport.desktop
chown root:root /usr/share/applications/litesoftware.desktop
chown root:root /usr/bin/lite-software
# File permissions
chmod 644 /usr/share/applications/createsysreport.desktop
chmod 644 /usr/share/applications/litesoftware.desktop

echo 'passed ownership'

# Folders and files permissions
chown root:root /usr/scripts -R
chmod 755 /usr/scripts -R

echo 'passed permissions'

chown root:root /usr/share/litesoftware -R
find /usr/share/litesoftware -type d -exec chmod 755 {} \;
find /usr/share/litesoftware -type f -exec chmod 644 {} \;
# This folder MUST have correct permissions for systems with multiple accounts
chown root:root /etc/skel -R
find /etc/skel -type d -exec chmod 755 {} \;
find /etc/skel -type f -exec chmod 644 {} \;

echo 'passed folders'

# UPDATE .desktop files
sed -i 's#Exec=.*#Exec=/usr/scripts/updates-gui#' /etc/skel/.local/share/applications/exo-file-manager.desktop # Install Updates

# Remove old files if exist

echo 'passed all'

ralphy@linuxlite:~/Desktop/devel$ sudo ./t.sh
[sudo] password for ralphy:
passed virtual box
passed ownership
passed permissions
passed folders
passed all


ralphy@linuxlite:~/Desktop/devel$ sudo sh -x t.sh
+ set -e
+ FILE=/etc/X11/Xsession.d/98vboxadd-xclient
+ [ -s /etc/X11/Xsession.d/98vboxadd-xclient ]
+ sudo sed -i s/notify-send/echo/g /etc/X11/Xsession.d/98vboxadd-xclient
+ echo passed virtual box
passed virtual box
+ chown root:root /usr/share/applications/createsysreport.desktop
+ chown root:root /usr/share/applications/litesoftware.desktop
+ chown root:root /usr/bin/lite-software
+ chmod 644 /usr/share/applications/createsysreport.desktop
+ chmod 644 /usr/share/applications/litesoftware.desktop
+ echo passed ownership
passed ownership
+ chown root:root /usr/scripts -R
+ chmod 755 /usr/scripts -R
+ echo passed permissions
passed permissions
+ chown root:root /usr/share/litesoftware -R
+ find /usr/share/litesoftware -type d -exec chmod 755 {} ;
+ find /usr/share/litesoftware -type f -exec chmod 644 {} ;
+ chown root:root /etc/skel -R
+ find /etc/skel -type d -exec chmod 755 {} ;
+ find /etc/skel -type f -exec chmod 644 {} ;
+ echo passed folders
passed folders
+ sed -i s#Exec=.*#Exec=/usr/scripts/updates-gui# /etc/skel/.local/share/applications/exo-file-manager.desktop
+ echo passed all
passed all

[valtam]

You've posted the lite-software postinst, not sure if that was your intention in regards to Lite Tweaks.

[ralphy]

You've posted the lite-software postinst, not sure if that was your intention in regards to Lite Tweaks.

MY BAD!

lite-tweaks package does error out because we have not updated the names in the script! I'm fixing it now and will push to master in a minute...

But I was trying to ask you to test the lite-software package which is completed at this time. I believe I got you confused by saying lite-tweaks when I meant to say lite-software.

Let's do something, give me 5 minutes and I will post back with committed changes that way you can go test what has been changed without wasting your time because of me. Sorry!

[valtam]

No need to apologize Ralphy.

[ralphy]

Thank you Jerry.

I have committed the changes to master.

1- lite-tweaks shouldn't error out anymore. Note that lite-tweaks is being renamed from litecleaner to lite-tweaks. The postinst file removes the old litecleaner.desktop so that users don't end up with two .desktop for the same application.

2- lite-software should have all updates I've worked on and tested. It shouldn't error out.

Please, do not release lite-tweaks yet. I want to address the Default browser issue. I'm looking into that next.